Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Protocol.validate API point #134

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

richardjgowers
Copy link
Contributor

@richardjgowers richardjgowers commented Feb 22, 2023

Not sure what the failure return should be;

  • plain False isn't constructive
  • raising an Error would prevent multiple failures being reported
  • maybe a list of strings, each an individual error message? (so empty list is success?)
  • maybe an Error, but with all the error messages concatenated?

Not sure what the failure return should be
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 97.95% // Head: 97.90% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (f5ffb8e) compared to base (628a4e0).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
- Coverage   97.95%   97.90%   -0.06%     
==========================================
  Files          38       38              
  Lines        1907     1909       +2     
==========================================
+ Hits         1868     1869       +1     
- Misses         39       40       +1     
Impacted Files Coverage Δ
gufe/protocols/protocol.py 92.64% <50.00%> (-1.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dwhswenson
Copy link
Member

It might be worth planning for this to eventually use ExceptionGroups (added in 3.11: PEP).

@mikemhenry
Copy link
Contributor

I agree with @dwhswenson so we should ideally raise exceptions and then once our min version is 3.11, we can switch to using exception groups.

@richardjgowers
Copy link
Contributor Author

see #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants