External resource updates #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes file copying when copying to a nested directory
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
=======================================
Coverage 99.20% 99.20%
=======================================
Files 36 36
Lines 1893 1898 +5
=======================================
+ Hits 1878 1883 +5
Misses 15 15 ☔ View full report in Codecov by Sentry. |
4 tasks
| @@ -20,6 +20,12 @@ def __init__(self, root_dir: Union[pathlib.Path, str]): | |||
| def _exists(self, location): | |||
| return self._as_path(location).exists() | |||
|
|
|||
| def __eq__(self, other): | |||
| return ( | |||
| isinstance(other, FileStorage) | |||
There was a problem hiding this comment.
a bit nickpicky, but technically objects are meant to return NotImplemented in this case, so that the other object can have a shot at defining __eq__, see https://stackoverflow.com/a/42588737
| @@ -26,6 +26,9 @@ def _delete(self, location): | |||
| f"Unable to delete '{location}': key does not exist" | |||
| ) | |||
|
|
|||
| def __eq__(self, other): | |||
| return self is other | |||
There was a problem hiding this comment.
iirc this is the default object behaviour, but I guess it isn't harming anyone having it here
richardjgowers
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things here:
ExternalResourcesFileStorageinto a nested directory.These were part of the overall work I've been doing on StagingPaths and the bigger storage tasks, but this is a small, self-contained PR that can be reviewed pretty easily. I thought it might be easier to review this first.