Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffold clustering #43

Merged
merged 13 commits into from
May 13, 2024
Merged

Scaffold clustering #43

merged 13 commits into from
May 13, 2024

Conversation

richardjgowers
Copy link
Contributor

No description provided.

@pep8speaks
Copy link

pep8speaks commented May 10, 2024

Hello @richardjgowers! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 15:80: E501 line too long (84 > 79 characters)

Line 32:80: E501 line too long (80 > 79 characters)
Line 33:80: E501 line too long (80 > 79 characters)
Line 38:80: E501 line too long (80 > 79 characters)
Line 53:80: E501 line too long (93 > 79 characters)
Line 66:80: E501 line too long (83 > 79 characters)
Line 81:80: E501 line too long (80 > 79 characters)
Line 86:80: E501 line too long (96 > 79 characters)
Line 88:80: E501 line too long (82 > 79 characters)
Line 95:80: E501 line too long (93 > 79 characters)
Line 116:80: E501 line too long (92 > 79 characters)

Line 6:80: E501 line too long (84 > 79 characters)

Comment last updated at 2024-05-12 18:44:36 UTC

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 98.96907% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.96%. Comparing base (66f4a3a) to head (37a6c0a).

Files Patch % Lines
...or/network_tools/clustering/scaffold_clustering.py 98.92% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   90.31%   90.96%   +0.64%     
==========================================
  Files          44       45       +1     
  Lines        1167     1262      +95     
==========================================
+ Hits         1054     1148      +94     
- Misses        113      114       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RiesBen RiesBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code looks pretty amazing!

Only a super detailed minor thing, rest is nice to read and cool concept!

@RiesBen RiesBen merged commit 823d5b1 into main May 13, 2024
6 checks passed
@RiesBen RiesBen deleted the scaffold_clustering branch August 5, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants