Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twin star Network #50

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Twin star Network #50

merged 3 commits into from
Jun 11, 2024

Conversation

RiesBen
Copy link
Contributor

@RiesBen RiesBen commented Jun 11, 2024

Content:

  • Add Twin Star Network Layout (inspired by OpenEye Layouts from Alchemistry2024)
  • Adding correction for weight calculation (transform scores into weights!)
  • Adding Scores to most tests.

@pep8speaks
Copy link

Hello @RiesBen! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 36:80: E501 line too long (83 > 79 characters)

Line 98:80: E501 line too long (83 > 79 characters)

Line 16:80: E501 line too long (83 > 79 characters)

Line 21:80: E501 line too long (83 > 79 characters)

Line 15:80: E501 line too long (87 > 79 characters)
Line 22:80: E501 line too long (83 > 79 characters)
Line 85:80: E501 line too long (84 > 79 characters)
Line 89:80: E501 line too long (86 > 79 characters)

Line 16:68: E252 missing whitespace around parameter equals
Line 20:80: E501 line too long (143 > 79 characters)
Line 25:80: E501 line too long (86 > 79 characters)
Line 27:80: E501 line too long (90 > 79 characters)
Line 31:80: E501 line too long (89 > 79 characters)
Line 33:80: E501 line too long (134 > 79 characters)
Line 34:80: E501 line too long (147 > 79 characters)
Line 39:80: E501 line too long (83 > 79 characters)
Line 42:80: E501 line too long (87 > 79 characters)
Line 49:5: E303 too many blank lines (2)
Line 49:80: E501 line too long (88 > 79 characters)
Line 66:9: E303 too many blank lines (2)
Line 82:9: E303 too many blank lines (2)

Line 24:41: E231 missing whitespace after ','
Line 24:43: E231 missing whitespace after ','
Line 34:25: E201 whitespace after '['
Line 34:80: E501 line too long (102 > 79 characters)

Line 40:86: W292 no newline at end of file

Line 5:80: E501 line too long (96 > 79 characters)
Line 29:79: W292 no newline at end of file

Line 33:80: E501 line too long (85 > 79 characters)

Line 19:41: E127 continuation line over-indented for visual indent
Line 21:5: E265 block comment should start with '# '
Line 27:80: E501 line too long (94 > 79 characters)
Line 29:80: E501 line too long (85 > 79 characters)

@RiesBen RiesBen added bug Something isn't working enhancement New feature or request labels Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.10%. Comparing base (65b9316) to head (6a043ca).

Files Patch % Lines
...tworkx_implementations/radial_network_algorithm.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   90.96%   91.10%   +0.13%     
==========================================
  Files          45       46       +1     
  Lines        1262     1293      +31     
==========================================
+ Hits         1148     1178      +30     
- Misses        114      115       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiesBen RiesBen merged commit 193a55d into main Jun 11, 2024
6 checks passed
@RiesBen RiesBen deleted the twin_star branch August 5, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants