Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor black #62

Merged
merged 20 commits into from
Aug 21, 2024
Merged

Refactor black #62

merged 20 commits into from
Aug 21, 2024

Conversation

RiesBen
Copy link
Contributor

@RiesBen RiesBen commented Aug 18, 2024

This PR is reafactoring the whole Repo with Black, improving the code readability.

Depends on #58 , as has the same origin.

Julicancode and others added 11 commits July 9, 2024 13:11
  * analysis:
* minor modifications on cycle analysis (only check for cylce of size 3 per default)
* make delete more performant, by deleting multiple transformations/components at once if wanted.
* adding graph cost and efficiency

  * jnbs:
*Adding text to Example JnB.

network -planners:
* minor refactors
* display fix, correct number of expected edges.
passing variable trough from top to bottom.
- Notebook improvements, more documentation, black formatting
- improving network generator documentation
- vscode -> gitignore
@RiesBen RiesBen self-assigned this Aug 18, 2024
@RiesBen RiesBen added the refactor Good Infrastrucutre / Refactoring label Aug 18, 2024
@RiesBen RiesBen linked an issue Aug 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 90.13605% with 29 lines in your changes missing coverage. Please review.

Project coverage is 90.90%. Comparing base (193a55d) to head (af0a844).
Report is 1 commits behind head on build_v1.

Files Patch % Lines
...work_planners/concatenators/cyclic_concatenator.py 0.00% 5 Missing ⚠️
src/konnektor/visualization/widget.py 77.27% 5 Missing ⚠️
src/konnektor/network_analysis/network_analysis.py 80.95% 4 Missing ⚠️
...planners/generators/clustered_network_generator.py 82.35% 3 Missing ⚠️
...tworkx_implementations/radial_network_algorithm.py 80.00% 2 Missing ⚠️
...k_planners/generators/_parallel_mapping_pattern.py 66.66% 2 Missing ⚠️
...erators/minimal_spanning_tree_network_generator.py 75.00% 2 Missing ⚠️
...dundant_minimal_spanning_tree_network_generator.py 80.00% 2 Missing ⚠️
src/konnektor/data/__init__.py 85.71% 1 Missing ⚠️
...tworkx_implementations/cyclic_network_algorithm.py 97.50% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##           build_v1      #62      +/-   ##
============================================
- Coverage     91.10%   90.90%   -0.21%     
============================================
  Files            46       46              
  Lines          1293     1308      +15     
============================================
+ Hits           1178     1189      +11     
- Misses          115      119       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiesBen RiesBen changed the base branch from main to build_v1 August 21, 2024 10:36
@RiesBen RiesBen merged commit 939f11c into build_v1 Aug 21, 2024
3 of 6 checks passed
@RiesBen RiesBen deleted the refactor_black branch August 21, 2024 10:46
@IAlibay
Copy link
Member

IAlibay commented Aug 21, 2024

@RiesBen the correct approach is to squash merge when applying black to a codebase, that way you don't overwrite your entire history - is this what you did here and/or can you isolate the commit where you applied black so we can put it in the git ignore list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Good Infrastrucutre / Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make code black
3 participants