Support outdir created at runtime #1072
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atravitz
commented
Jan 10, 2025
| ), | ||
| ) | ||
| @click.option( | ||
| 'output', '-o', default=None, | ||
| type=click.Path(dir_okay=False, file_okay=True, path_type=pathlib.Path), | ||
| type=click.Path(dir_okay=False, file_okay=False, path_type=pathlib.Path), |
There was a problem hiding this comment.
the click.File option exists and is neat, but not applicable here since the default behavior relies on the transformation name
|
No API break detected ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1072 +/- ##
==========================================
- Coverage 94.47% 92.74% -1.73%
==========================================
Files 135 135
Lines 10092 10090 -2
==========================================
- Hits 9534 9358 -176
- Misses 558 732 +174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #986 (comment)
Checklist
newsentryDevelopers certificate of origin