(tlg2042 new texts) new OGL work #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlisonBabeu
reviewed
Sep 7, 2023
There was a problem hiding this comment.
hi @lcerrato Is this a file change that was left over from another pull request?
There was a problem hiding this comment.
No, it's a correction. Charlotte was listed twice.
AlisonBabeu
reviewed
Sep 7, 2023
There was a problem hiding this comment.
Only thing I noticed was that you encoded editor two separate ways in the structured bibliographic section.
<editor><persName>Jean Baptiste Pitra</persName></editor> <editor>Hermann Mutschmann</editor>
AlisonBabeu
reviewed
Sep 7, 2023
| <monogr> | ||
| <author>Origen</author> | ||
| <title xml:lang="lat">Analecta sacra spicilegio solesmensi parata</title> | ||
| <editor><persName>Jean Baptiste Pitra</persName></editor> |
There was a problem hiding this comment.
Again, here editor encoded two different ways.
There was a problem hiding this comment.
This is how the file was encoded when I opened it plus probably copy/paste. Will fix.
AlisonBabeu
approved these changes
Sep 7, 2023
|
@AlisonBabeu Can you double check the last commit here? I made requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2747
fix #2748
Note that I think a large chunk of the Psalms is missing or was never captured.