(new_submissions) adding tlg0544.tlg001.1st1K-eng1.xml file #2792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Greek into new_submissions * 'master' of https://github.com/OpenGreekAndLatin/First1KGreek: tlg0559_all_files(almost)
…file; initial structure issues #2791
… added cts and fixed volume info #2791
…n/First1KGreek into new_submissions * 'new_submissions' of https://github.com/OpenGreekAndLatin/First1KGreek: (new_submissions) further work on tlg0544.tlg001.1st1K-eng1.xml file #2791
missing end tag
…Greek into new_submissions * 'master' of https://github.com/OpenGreekAndLatin/First1KGreek: Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows
|
@AlisonBabeu Would you double check the metadata and header? |
AlisonBabeu
reviewed
Sep 9, 2024
There was a problem hiding this comment.
hi @lcerrato the only thing I think that needs changing is the <title>Outlines of Pyrrhonism</title> in the '' should instead be the title of the published volume itself, namely Sextus Empiricus.
I checked and we had examples of both, where this is the Volume subtitle. We can/should revise as needed. |
changed book title based on comments
AlisonBabeu
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2791