Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom config files #212

Merged
merged 25 commits into from
Sep 6, 2023
Merged

Support custom config files #212

merged 25 commits into from
Sep 6, 2023

Commits on Sep 1, 2023

  1. change config file logic (OpenLiberty#194) 

    * config logic swap
    @dshimo @evie-lau
    dshimo authored and evie-lau committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    b7ff73c View commit details
    Browse the repository at this point in the history

  2. Fix determination of Liberty Workspace for non-default server.xml (Op… 

    …enLiberty#201)

* Fix determination of Liberty Workspace for non-default server.xml

* Clean up
    @cherylking @evie-lau
    cherylking authored and evie-lau committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    e025c59 View commit details
    Browse the repository at this point in the history

  3. xmlreader on config portion

    @dshimo @evie-lau
    dshimo authored and evie-lau committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    6acab22 View commit details
    Browse the repository at this point in the history

  4. Initial changes to watch and process liberty-plugin-config.xml

    @evie-lau
    evie-lau committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    a7b4a60 View commit details
    Browse the repository at this point in the history

  5. Process and store custom config files

    @evie-lau
    evie-lau committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    f59e641 View commit details
    Browse the repository at this point in the history

  6. init test, refactor to use LCFM

    @dshimo @evie-lau
    dshimo authored and evie-lau committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    3df2de1 View commit details
    Browse the repository at this point in the history

  7. Initial tests. Small refactor

    @evie-lau
    evie-lau committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    ad35bf3 View commit details
    Browse the repository at this point in the history

  8. Fix uri string mismatch. Update key completion to use file-checking m… 

    …ethods.
    @evie-lau
    evie-lau committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    1c303fe View commit details
    Browse the repository at this point in the history

  9. Update comments and todos

    @evie-lau
    evie-lau committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    146a267 View commit details
    Browse the repository at this point in the history

  10. Add check for config file path, moved from client-side filewatch filt… 

    …ering
    @evie-lau
    evie-lau committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    41c4c30 View commit details
    Browse the repository at this point in the history

  11. Fix paths for windows

    @evie-lau
    evie-lau committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    93ff57a View commit details
    Browse the repository at this point in the history

  12. init custom config files list

    @dshimo @evie-lau
    dshimo authored and evie-lau committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    6807f9c View commit details
    Browse the repository at this point in the history

  13. Normalize paths. Test still fails on Windows because test file has un… 

    …ix path
    @evie-lau
    evie-lau committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    6c55625 View commit details
    Browse the repository at this point in the history

  14. Run custom config file test in Unix only

    @evie-lau
    evie-lau committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    763c653 View commit details
    Browse the repository at this point in the history

  15. Modify tests to account for Windows

    @evie-lau
    evie-lau committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    5d4de2b View commit details
    Browse the repository at this point in the history

  16. Cleanup comments and add copyright

    @evie-lau
    evie-lau committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    8bfd08e View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Update filenames to use URI formatted string

    @evie-lau
    evie-lau committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    529c6ea View commit details
    Browse the repository at this point in the history

  2. PR comments and cleanup

    @dshimo
    dshimo committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    a7ae07b View commit details
    Browse the repository at this point in the history

  3. oops

    @dshimo
    dshimo committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    0ac0973 View commit details
    Browse the repository at this point in the history

  4. Minor fixes

    @evie-lau
    evie-lau committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    07d6414 View commit details
    Browse the repository at this point in the history

  5. Fix Windows pathing 

    Co-authored-by: David Shi <dshi@utexas.edu>
    @evie-lau @dshimo
    evie-lau and dshimo committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    5e8b0aa View commit details
    Browse the repository at this point in the history

  6. Fix parse on file change. 

    Co-authored-by: David Shi <dshi@utexas.edu>
    @evie-lau @dshimo
    evie-lau and dshimo committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    95cc901 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Make sure build/test actions are separate. Suppress progress tracking… 

    … for downloads

Make sure Windows paths are converted to use forward slash

Test different approach for unix/windows systems

Use URI.getPath for windows Paths.get

Try removing initial slash when checking windows path

Fix default file check with File.separator

Fix windows test string
    @evie-lau
    evie-lau committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    1043bbe View commit details
    Browse the repository at this point in the history

  2. Add comments, use constants

    @evie-lau
    evie-lau committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    c8f4a3a View commit details
    Browse the repository at this point in the history

  3. Modify initCustomConfigTest to use a separate test resource folder

    @evie-lau
    evie-lau committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    74620ab View commit details
    Browse the repository at this point in the history