Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change file monitoring for LCLS #490

Closed
evie-lau opened this issue Sep 6, 2023 · 0 comments · Fixed by #510
Closed

Change file monitoring for LCLS #490

evie-lau opened this issue Sep 6, 2023 · 0 comments · Fixed by #510
Assignees
Labels
enhancement New feature or request

Comments

@evie-lau
Copy link
Member

evie-lau commented Sep 6, 2023

To support custom config files, after OpenLiberty/liberty-language-server#212 goes in, the IDE client side needs to be changed to monitor the following to send to LCLS:

  • all .env and .properties files - language support
  • liberty-plugin-config.xml - watch file for changes
    • since IJ doesn't currently have built-in LSP support, may have to add our own Listener or File Watcher implementation and link it to the LibertyWorkspaceService

<languageMapping language="Properties" serverId="libertyls"
filePattern="**/{src/main/liberty/config,usr/servers/**}/{bootstrap.properties,server.env}"/>

Whether or not this change is implemented shouldn't break anything, but will not have support for custom config files.

Can model after OpenLiberty/liberty-tools-vscode#286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants