Add filewatcher to enable custom config support for LCLS #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CLS, add small clarifications
cherylking
reviewed
Oct 4, 2023
src/main/java/io/openliberty/tools/intellij/liberty/lsp/LibertyCustomConfigListener.java
Show resolved
Hide resolved
cherylking
reviewed
Oct 4, 2023
src/main/java/io/openliberty/tools/intellij/liberty/lsp/LibertyCustomConfigManager.java
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/intellij/liberty/lsp/LibertyCustomConfigManager.java
Outdated
Show resolved
Hide resolved
TrevCraw
approved these changes
Oct 18, 2023
src/main/java/io/openliberty/tools/intellij/lsp4mp/lsp4ij/LanguageServerWrapper.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/intellij/liberty/lsp/LibertyCustomConfigManager.java
Outdated
Show resolved
Hide resolved
TrevCraw
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #490
Add file listener - notify LCLS to process
liberty-plugin-config.xmlfiles when a filechange is detected.Also requires LCLS 2.1 or 2.1-SNAPSHOT
Merging this change does not break existing support for LCLS files.
Notes
Currently this only works if
liberty-plugin-config.xmlchanges after IntelliJ/LCLS is initialized.Liberty Tools IntelliJ doesn't initialize workspace folders, which is how the custom config files are discovered on LCLS initialization. Related to #483
Also to note, it seems the intellij-quarkus plugin has made changes to enable workspace folders, and also enable the LSP protocol for
workspace/didChangeWatchedFiles, which may replace these changes at some point in the future.