Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable debug in development #310

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Enable debug in development #310

merged 3 commits into from
Dec 5, 2023

Conversation

evie-lau
Copy link
Member

@evie-lau evie-lau commented Nov 9, 2023

No description provided.

@evie-lau evie-lau mentioned this pull request Nov 9, 2023
Merged
dshimo
dshimo approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@dshimo dshimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad the debug works.
I would prefer the debug ports to not be in blockquotes but it's a negligible detail.

@evie-lau
Copy link
Member Author

I would prefer the debug ports to not be in blockquotes but it's a negligible detail.

Agreed, and changed in new commit.

Note to hold off on merging this until after the upcoming release.

@evie-lau evie-lau merged commit e6f1f16 into OpenLiberty:main Dec 5, 2023
4 checks passed
@evie-lau evie-lau deleted the debug branch December 5, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshimo dshimo dshimo approved these changes

@TrevCraw TrevCraw Awaiting requested review from TrevCraw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evie-lau @dshimo