Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing s3 benchmark from nkv-minio artifact #16

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Removing s3 benchmark from nkv-minio artifact #16

merged 1 commit into from
Nov 9, 2023

Conversation

nsarras
Copy link
Contributor

@nsarras nsarras commented Oct 18, 2023

No description provided.

@nsarras nsarras linked an issue Oct 18, 2023 that may be closed by this pull request
[Build Pipeline] Remove S3 Benchmark binary from nkv-minio artifact build #15
Closed
@nsarras nsarras requested a review from a team as a code owner October 18, 2023 00:26
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

velomatt
velomatt approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@velomatt velomatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's hold off on merging until changes from other affected repos are in as well, and merge them all together (eg, dss-ansible, dss-ecosystem)

@nsarras nsarras mentioned this pull request Nov 7, 2023
Merged
@nsarras nsarras merged commit df81c52 into master Nov 9, 2023
3 checks passed
@nsarras nsarras deleted the 15-build-pipeline-remove-s3-benchmark-binary-from-nkv-minio-artifact-build branch November 9, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velomatt velomatt velomatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Build Pipeline] Remove S3 Benchmark binary from nkv-minio artifact build
2 participants
@nsarras @velomatt