Memory pool support for Replication IO #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ip-mem-alloc-replication
rajpayagond
suggested changes
Oct 25, 2023
cmd/erasure-utils.go
Outdated
| divFactor = 2 * divFactor | ||
| minSize = globalMaxKVObject/int64 (divFactor) | ||
| for (minSize <= 32768) { | ||
| midSize = (2 * globalMaxKVObject)/int64 (divFactor) |
There was a problem hiding this comment.
allocating for minSize not midSize
There was a problem hiding this comment.
good catch, will resolve, thx
rajpayagond
approved these changes
Oct 25, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Memory pool support for Replication IO.
Description
Memory pool support for Replication IO. Configurable three different memory pool size and based on the IO size the closest memory pool will be selected. This will enable IO size > 1MB in the DSS Minio KV stack.
Motivation and Context
To support > 1MB IO in the Minio KV path.
Regression
How Has This Been Tested?
Unit testing with single node setup. Performance tested on single minio with 1MB and 8 MB.
Disclaimer because of target issue of supporting large number of bigger IOs, can't stress with more ios in my test.
Types of changes
Checklist:
mintPR # here: )