Skip to content
This repository has been archived by the owner on May 18, 2019. It is now read-only.

[BE] Added usage of failtrace debug flag #2357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kabdelhak
Copy link
Contributor

  • BackendEquation.solveEquation

- BackendEquation.solveEquation
@CLAassistant
Copy link

CLAassistant commented Apr 11, 2018

CLA assistant check
All committers have signed the CLA.

@OpenModelica-Hudson
Copy link
Member

The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2018-04-11_18-16-17.

@lochel
Copy link
Member

lochel commented May 8, 2018

Welcome @kabdelhak. Thanks for your first contribution.
Why do you want to hide the error message? Is the function supposed to fail and the test suite doesn't cover that case?

@kabdelhak
Copy link
Contributor Author

kabdelhak commented May 8, 2018 via email

@lochel
Copy link
Member

lochel commented May 14, 2018

@kabdelhak, @wibraun Do you have a model where this function actually fails? It should obviously fail for algorithms, when equations, and if equations. However, if it is not expected to reach one of these cases, then I would rather keep the error message explicit.

@wibraun
Copy link
Member

wibraun commented May 14, 2018

@lochel It depends on the usage of this function. If one would like to use it as a try and in failing case do something else, than the error message is totally misleading, especially for end-users. So I think it's okay to hide it. In the new removeSimpleEquations module is used like that and therefore I proposed to hide the error messages instead of having them in all related tests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants