This repository has been archived by the owner on May 18, 2019. It is now read-only.
[BE] Fix handling of mixed determined systems #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kabdelhak
commented
May 10, 2019
kabdelhak
commented
- add all variable indices to artifical functions in adjacency matrix
- ticket #5170
- add all variable indices to artifical functions in adjacency matrix - ticket #5170
|
This actually fixes ticket #5170, but several other models like Feel free to comment the code! |
|
I can't see the results of the testsuite. Maybe you can run it on this PR, so we can check? |
|
The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2019-05-10_16-24-49. |
lochel
reviewed
May 10, 2019
| @@ -1426,7 +1425,8 @@ algorithm | |||
| outM := arrayCreate(inNEqns+inNAddEqns, {}); | |||
| outM := Array.copy(inM, outM); | |||
| newEqIndices := List.intRange2(inNEqns+1, inNEqns+inNAddEqns); | |||
| outM := List.fold1(newEqIndices, squareIncidenceMatrix1, inInitVarIndices, outM); | |||
| allVarIndices := List.intRange2(1,inNEqns+inNAddEqns); | |||
| outM := List.fold1(newEqIndices, squareIncidenceMatrix1, allVarIndices, outM); | |||
There was a problem hiding this comment.
This doesn't look right to me. The introduced artificial equations should only be connected to inInitVarIndices (states, discrete states, and parameters having fixed=false).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.