OCD format enhancements #2148
Open
OCD format enhancements #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dominant color id is stored both in the index entry and the main object struct. Amends commit 6d5d317 (OcdFileExport: Set color in object index entry).
The export routines store the "show at least one gap" line symbol property as the OCD minimum number of gaps/symbols. This commit complements the export path code and implements translation from the number of gaps/symbols to the Mapper symbol property. Amends commit 908d404 (Implement export to .ocd version 8).
Starting from v12 format the object features fields for creation and modification times. Some users use the modification time to identify changed objects. Mapper can support this workflow by maintaining the creation and modification times on the map objects. This patch does not implement object timestamp updates in Mapper. The conversion of the floating point number to date and time is described at https://docwiki.embarcadero.com/Libraries/Alexandria/en/System.TDateTime
Examination of real OCD files has revealed that the server object id is customarily filled with -1.
|
Libor, thank you for the PR. |
|
Thanks, Matthias, for the review! I'm not against addition of the timestamps as an object property and I can implement it if the feature is aligned with the project roadmap. |
dl3sdo
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set is related to various OCD format support enhancements. The first two commits complement existing changes in the repo. The next two add new functionality for the sake of compatibility. I'd be happy if they were merged into the mainline Mapper code.