JSON based Mapper configuration #2157
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to the configuration of Mapper through the 'Settings' GUI where a dedicated control element is needed for each setting, this commit implements a lightweight mechanism by using a JSON configuration file that allows to easily configure a variety of settings. The 'Settings' GUI is extended by the possibility to select and remember the JSON configuration to be used as default configuration. An additional dialog allows to load and save JSON configuration and provides a simple, i.e., not context-sensitive, text editor. The validity of the JSON format is checked and deviations to Mapper's default JSON configuration can be shown and resolved.
The declination lookup at www.ngdc.noaa.gov now requests the additional parameter 'key'. This commit uses the JSON configuration mechanism which provides the default value for the 'key' parameter while allowing to change the value by the user. It supersedes OpenOrienteering#2088 and closes OpenOrienteering#2087.
This commit adds a helper function that analyzes a given symbol whether it is either a line symbol or a combined symbol containing line symbols and if any of the line symbols contains a dash symbol.
When drawing line objects for symbols with dash symbols, no dash points were set automatically if the symbol was a combined symbol. When editing line objects for symbols with dash symbols, additional points were not added as dash points if the symbol was a combined symbol. These deviations were known and marked as TODO. This commit treats line symbols with dash symbols and combined symbols containing line symbols with dash symbols equally.
Use JSON configuration to enable or disable the automatic setting of dash points for symbols with dash symbols. Closes OpenOrienteering#1961
Arrange class forward declarations and include files in alphabetical order and add missing include files.
|
I think this is just great. If more config options can find its way down here, that would be awesome. Also custom colors for scribbling might perhaps be stored in here (#1738)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the configuration of Mapper through the 'Settings' GUI where a dedicated control element is needed for each setting, this commit implements a lightweight mechanism by using a JSON configuration file that allows to easily configure a variety of settings.
The 'Settings' GUI is extended by the possibility to select and remember the JSON configuration to be used as default configuration.
An additional dialog allows to load and save JSON configuration and provides a simple, i.e., not context-sensitive, text editor.
The validity of the JSON format is checked and deviations to Mapper's default JSON configuration can be shown and resolved.
As examples for its usage it closes #2087 and closes #1961, thus superseding #2088 and #2154.
Note: this is currently just a POC and there are some TODOs:
However, before continuing I need feedback whether this kind of JSON based configuration is desired at all.