IofCourseExport: Add 'Map' element #2168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg0yt
reviewed
Jul 7, 2023
dg0yt
reviewed
Apr 13, 2024
Comment on lines
+113
to
+128
| // IOF.xsd proposes for 'MapPositionTopLeft': "The position of the map's top left corner given in the map's coordinate system, usually (0, 0)." | ||
| // However, the real coordinates from the map_extent structure are used below. | ||
| // NOTE: templates are considered when determining the map extent. | ||
| const auto map_extent = map->calculateExtent(true, true, view); | ||
| { | ||
| XmlElementWriter map_position_topleft(*xml, QLatin1String("MapPositionTopLeft")); | ||
| map_position_topleft.writeAttribute(QLatin1String("x"), QString::number(map_extent.topLeft().x())); | ||
| map_position_topleft.writeAttribute(QLatin1String("y"), QString::number(map_extent.topLeft().y())); | ||
| map_position_topleft.writeAttribute(QLatin1String("unit"), QLatin1String("mm")); // optional attribute, default is 'mm' | ||
| } | ||
| { | ||
| XmlElementWriter map_position_bottomright(*xml, QLatin1String("MapPositionBottomRight")); | ||
| map_position_bottomright.writeAttribute(QLatin1String("x"), QString::number(map_extent.bottomRight().x())); | ||
| map_position_bottomright.writeAttribute(QLatin1String("y"), QString::number(map_extent.bottomRight().y())); | ||
| map_position_bottomright.writeAttribute(QLatin1String("unit"), QLatin1String("mm")); // optional attribute, default is 'mm' | ||
| } |
There was a problem hiding this comment.
Is the extent information useful at all when not also providing the Image element?
There was a problem hiding this comment.
Is the extent information useful at all when not also providing the
Imageelement?
Good question, but I assume yes, since the 'Image' element is not mandatory and the PR works for the issue reporter due to #2166
The 'Map' element is added to the IOF 3.0 compliant xml export of course data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Map' element is added to the IOF 3.0 compliant xml export of course data.
This commit partly solves #2167, #2166.