Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DrawPathTool: Highlight object that is going to be followed #2179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lpechacek
Copy link
Member

In complex map situations it is unclear which object will be followed when the user uses the Shift modifier key to follow lines or area object boundaries. This is a proposal how to make the object selection more obvious.

Note the dashed object boundary highlight in the video.

Screencast.from.2023-09-06.15-49-27.webm

In complex map situations it is unclear which object will be followed
when the user uses the Shift modifier key to follow lines or area object
boundaries. This change makes the object selection more obvious.
@mlerjen
Copy link
Contributor

mlerjen commented Sep 7, 2023

The clarification which object you follow is welcomed. To make it really useful it should be combined with the possibilty to "loop" through the possible objects on the actual click location. Thus a repeated crtl & click on the (+/-) same spot with no "drag" added, should result in this "loop".

(e.g. while "following" a line shared by multiple objects, I sometimes somehow am able to switch the object to follow and sometimes I ain't. The logic behind seems unclear. With the highlighting of the object to follow as @lpechacek proposes, this could make the logic clear, but anyway. I'd like to have the choice which object to follow at any given point )

@lpechacek
Copy link
Member Author

Thanks for the comment, @mlerjen . I'm happy that my contributions still spark interest in the user community. :)

To make it really useful it should be combined with the possibilty to "loop" through the possible objects on the actual click location.

Agreed. Only after adding the "followed object highlight" I realized that it's always the closest object that is followed. Before the new feature addition I thought that Mapper cycles between the available objects but I just don't see it. So, implementation of the object cycling (in fact a borrow from the edit point tool) is a logical next step. I'm, however not sure if I'm to implement it as this deficiency doesn't itch me that strong.

Thus a repeated crtl & click on the (+/-) same spot with no "drag" added, should result in this "loop".

And the repeated click should not add extra vertices on the path. The extra points added by the draw path tool bother me quite a lot, starting with the extra point added on the first click with follow path. IMO, the draw path tool should automatically merge new points added by clicking within click distance on the new path, for example when starting a new path or switching between followed objects.

@eolmapper
Copy link

I tested the PR, it’s a very good idea!
On the other hand, I find that the highlight with the red dash line is not always clearly visible and brings a confusion with the red editing object line.
It may be necessary to change the color or type of symbol.
Why not dots instead of the dash line?

@lpechacek
Copy link
Member Author

@eolmapper , thanks for the feedback! I looked into the dots version of the object highlight. The draft version is in #2204. Let me know if that highlight method feels better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants