Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add selfplay test #275

Merged
merged 8 commits into from
Nov 24, 2023
Merged

add selfplay test #275

merged 8 commits into from
Nov 24, 2023

Conversation

huangshiyu13
Copy link
Member

@huangshiyu13 huangshiyu13 commented Nov 23, 2023

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have ensured make test pass (required).
  • I have checked the code using make format (required).

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (58c022f) 62.78% compared to head (714a9ec) 66.09%.
Report is 4 commits behind head on main.

Files Patch % Lines
openrl/selfplay/callbacks/selfplay_api.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   62.78%   66.09%   +3.30%     
==========================================
  Files         255      252       -3     
  Lines       13466    13156     -310     
==========================================
+ Hits         8455     8695     +240     
+ Misses       5011     4461     -550     
Flag Coverage Δ
unittests 66.09% <80.00%> (+3.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@huangshiyu13 huangshiyu13 merged commit 91ac0df into OpenRL-Lab:main Nov 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant