Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: map smooth animation configuration for pathfinding errors #8406

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Aug 9, 2024

Fix #8404

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 39.06%. Comparing base (02e76f0) to head (b375a45).
Report is 19 commits behind head on dev.

Files with missing lines Patch % Lines
...bleConstraints/IncompatibleConstraintsMapFocus.tsx 0.00% 7 Missing ⚠️
...patibleConstraints/IncompatibleConstraintsList.tsx 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8406      +/-   ##
============================================
- Coverage     39.14%   39.06%   -0.08%     
  Complexity     2267     2267              
============================================
  Files          1306     1308       +2     
  Lines         99040    99202     +162     
  Branches       3311     3312       +1     
============================================
- Hits          38770    38757      -13     
- Misses        58308    58482     +174     
- Partials       1962     1963       +1     
Flag Coverage Δ
core 74.93% <ø> (-0.04%) ⬇️
editoast 71.96% <ø> (-0.06%) ⬇️
front 10.33% <0.00%> (-0.03%) ⬇️
gateway 2.50% <ø> (ø)
osrdyne 3.29% <ø> (-0.01%) ⬇️
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sim51 sim51 marked this pull request as ready for review August 9, 2024 12:52
@sim51 sim51 requested a review from a team as a code owner August 9, 2024 12:52
@sim51 sim51 force-pushed the bsi/issue-8404 branch 3 times, most recently from 606a386 to fc6cae8 Compare October 21, 2024 12:41
@sim51 sim51 enabled auto-merge October 21, 2024 13:33
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, thank your for the fix !

It has been decided to postponed the fix for the path focus animation (always not smooth for now) as it requires many changes.

@sim51 sim51 added this pull request to the merge queue Oct 22, 2024
Fix #8404

Signed-off-by: Benoit Simard <contact@bsimard.com>
@sim51 sim51 removed this pull request from the merge queue due to a manual request Oct 22, 2024
@sim51 sim51 enabled auto-merge October 22, 2024 09:55
@sim51 sim51 added this pull request to the merge queue Oct 22, 2024
Merged via the queue into dev with commit 26ea2f6 Oct 22, 2024
24 checks passed
@sim51 sim51 deleted the bsi/issue-8404 branch October 22, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: pathfinding error and swicth for smooth map animation
3 participants