Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: schedule table : fix 00:00:00 stop input #8956

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

Akctarus
Copy link
Contributor

fix #8925

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 25.77%. Comparing base (a09a974) to head (18d104f).
Report is 46 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/modules/timesStops/helpers/utils.ts 54.54% 0 Missing and 5 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (a09a974) and HEAD (18d104f). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (a09a974) HEAD (18d104f)
railjson_generator 2 1
osrdyne 2 1
gateway 2 1
tests 2 1
front 2 1
core 2 1
editoast 2 0
Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #8956       +/-   ##
=============================================
- Coverage     37.11%   25.77%   -11.34%     
- Complexity     2241     2242        +1     
=============================================
  Files          1262     1001      -261     
  Lines        115835    91133    -24702     
  Branches       3277     3280        +3     
=============================================
- Hits          42995    23492    -19503     
+ Misses        70886    65686     -5200     
- Partials       1954     1955        +1     
Flag Coverage Δ
core 74.78% <ø> (-0.02%) ⬇️
editoast ?
front 15.33% <54.54%> (+0.13%) ⬆️
gateway 2.22% <ø> (+<0.01%) ⬆️
osrdyne 2.56% <ø> (-0.01%) ⬇️
railjson_generator 87.49% <ø> (ø)
tests 86.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus marked this pull request as ready for review September 24, 2024 07:31
@Akctarus Akctarus requested a review from a team as a code owner September 24, 2024 07:31
@Akctarus Akctarus force-pushed the tmn/front/fix-schedule-table-midnight-stop branch 7 times, most recently from eed464d to 9e563a8 Compare October 1, 2024 08:38
@Akctarus Akctarus force-pushed the tmn/front/fix-schedule-table-midnight-stop branch 4 times, most recently from f8ae378 to 0fd17c0 Compare October 1, 2024 14:22
@Akctarus Akctarus force-pushed the tmn/front/fix-schedule-table-midnight-stop branch 2 times, most recently from ede9d00 to 6754f98 Compare October 2, 2024 09:53
Copy link
Contributor

@anisometropie anisometropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for earlier changes :) Just one last case that’s not handled correctly

Copy link
Contributor

@anisometropie anisometropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

Signed-off-by: Theo Macron <theo.macron0315@gmail.com>
@Akctarus Akctarus force-pushed the tmn/front/fix-schedule-table-midnight-stop branch from b0e09f4 to 18d104f Compare October 2, 2024 14:17
@Akctarus Akctarus added this pull request to the merge queue Oct 2, 2024
Merged via the queue into dev with commit 1ac8c11 Oct 2, 2024
23 checks passed
@Akctarus Akctarus deleted the tmn/front/fix-schedule-table-midnight-stop branch October 2, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

00:00:00 doesn't seem to be a valid time input
5 participants