Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add times and stops e2e test for operational studies #8961

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

Maymanaf
Copy link
Contributor

Closes #8646

@Maymanaf Maymanaf force-pushed the aba/e2e-op-times-and-stops branch 5 times, most recently from 4f0d9cd to a1ecb0e Compare September 24, 2024 20:29
@Maymanaf Maymanaf marked this pull request as ready for review September 24, 2024 20:29
@Maymanaf Maymanaf requested a review from a team as a code owner September 24, 2024 20:29
@emersion
Copy link
Member

This component will be re-designed and rewritten soon. I wonder, is now a good time to merge a test, given we're going to have to rewrite it soon?

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this test, but it sometimes fails locally and is flaky in the CI

@Maymanaf Maymanaf force-pushed the aba/e2e-op-times-and-stops branch 14 times, most recently from dc3cadf to 2b1c132 Compare October 1, 2024 14:17
@kmer2016
Copy link
Contributor

kmer2016 commented Oct 1, 2024

This component will be re-designed and rewritten soon. I wonder, is now a good time to merge a test, given we're going to have to rewrite it soon?

After talking with @clarani, we both think it still makes sense to merge these tests. Since the structure will mostly change but the content will stay the same, this will help standardize the input table and make it easier when we update it later.

@Maymanaf Maymanaf force-pushed the aba/e2e-op-times-and-stops branch 2 times, most recently from 2f738ed to a6d47cc Compare October 1, 2024 16:30
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested

front/tests/pages/op-timetable-page-model.ts Outdated Show resolved Hide resolved
Signed-off-by: maymanaf <med.aymen.naf@gmail.com>
@Maymanaf Maymanaf added this pull request to the merge queue Oct 3, 2024
Merged via the queue into dev with commit 0f97f32 Oct 3, 2024
24 checks passed
@Maymanaf Maymanaf deleted the aba/e2e-op-times-and-stops branch October 3, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: add e2e tests operational studies - times & stops
5 participants