-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: add times and stops e2e test for operational studies #8961
Conversation
4f0d9cd
to
a1ecb0e
Compare
a1ecb0e
to
4138127
Compare
This component will be re-designed and rewritten soon. I wonder, is now a good time to merge a test, given we're going to have to rewrite it soon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this test, but it sometimes fails locally and is flaky in the CI
dc3cadf
to
2b1c132
Compare
After talking with @clarani, we both think it still makes sense to merge these tests. Since the structure will mostly change but the content will stay the same, this will help standardize the input table and make it easier when we update it later. |
2b1c132
to
8e5b61e
Compare
2f738ed
to
a6d47cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested
a6d47cc
to
6e776b0
Compare
6e776b0
to
2a4a2a0
Compare
Signed-off-by: maymanaf <med.aymen.naf@gmail.com>
2a4a2a0
to
063f3c4
Compare
Closes #8646