-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: convert base64 encoded map image to jpeg #9029
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9029 +/- ##
============================================
- Coverage 37.53% 37.51% -0.02%
Complexity 2242 2242
============================================
Files 1256 1256
Lines 114937 114999 +62
Branches 3271 3271
============================================
+ Hits 43143 43147 +4
- Misses 69848 69906 +58
Partials 1946 1946
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
front/src/applications/stdcm/components/SimulationReportSheet.tsx
Outdated
Show resolved
Hide resolved
f8f0ff7
to
1f0cb28
Compare
front/src/applications/stdcm/utils/formatSimulationReportSheet.ts
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/components/SimulationReportSheet.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/components/SimulationReportSheet.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/components/SimulationReportSheet.tsx
Outdated
Show resolved
Hide resolved
90c084c
to
fee1462
Compare
front/src/applications/stdcm/components/SimulationReportSheet.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/utils/formatSimulationReportSheet.ts
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/components/SimulationReportSheet.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with that nit fixed, but not tested! (feel free to resolve the discussion)
4857d0c
to
fef7f15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, lgtm :)
Signed-off-by: Theo Macron <theo.macron0315@gmail.com>
fef7f15
to
1fe68d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, nice improvement
closes #8978
The map image was just base64 encoded, now we convert it to jpeg and reduce its quality a little, saving up to 500KB