Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: convert base64 encoded map image to jpeg #9029

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Sep 26, 2024

closes #8978

The map image was just base64 encoded, now we convert it to jpeg and reduce its quality a little, saving up to 500KB

@Akctarus Akctarus requested a review from a team as a code owner September 26, 2024 15:04
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 12.50000% with 56 lines in your changes missing coverage. Please review.

Project coverage is 37.51%. Comparing base (5a6ae29) to head (1fe68d2).
Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
...cations/stdcm/utils/formatSimulationReportSheet.ts 21.05% 30 Missing ⚠️
...cations/stdcm/components/SimulationReportSheet.tsx 0.00% 25 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9029      +/-   ##
============================================
- Coverage     37.53%   37.51%   -0.02%     
  Complexity     2242     2242              
============================================
  Files          1256     1256              
  Lines        114937   114999      +62     
  Branches       3271     3271              
============================================
+ Hits          43143    43147       +4     
- Misses        69848    69906      +58     
  Partials       1946     1946              
Flag Coverage Δ
core 74.78% <ø> (ø)
editoast 72.04% <ø> (-0.02%) ⬇️
front 15.57% <12.50%> (-0.01%) ⬇️
gateway 2.22% <ø> (ø)
osrdyne 2.56% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/front/lighter-stdcm-map-image branch 2 times, most recently from f8f0ff7 to 1f0cb28 Compare October 1, 2024 08:56
@Akctarus Akctarus force-pushed the tmn/front/lighter-stdcm-map-image branch from 90c084c to fee1462 Compare October 2, 2024 15:54
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with that nit fixed, but not tested! (feel free to resolve the discussion)

@Akctarus Akctarus force-pushed the tmn/front/lighter-stdcm-map-image branch from 4857d0c to fef7f15 Compare October 3, 2024 13:31
Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, lgtm :)

Signed-off-by: Theo Macron <theo.macron0315@gmail.com>
@Akctarus Akctarus force-pushed the tmn/front/lighter-stdcm-map-image branch from fef7f15 to 1fe68d2 Compare October 4, 2024 08:12
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, nice improvement

@Akctarus Akctarus added this pull request to the merge queue Oct 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@Akctarus Akctarus added this pull request to the merge queue Oct 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@Akctarus Akctarus added this pull request to the merge queue Oct 4, 2024
Merged via the queue into dev with commit 59b86f6 Oct 4, 2024
25 checks passed
@Akctarus Akctarus deleted the tmn/front/lighter-stdcm-map-image branch October 4, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make STDCM simulation sheet lighter
5 participants