Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast, osrdyne: fix the multi infra status response #9041

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Sep 27, 2024

  • Build up list querys correctly on editoast side
  • Aggregate the worker status results correctly on editoast side
  • Use a by worker_id map (instead of a by worker_key) in osrdyne response

@Khoyo Khoyo requested review from a team as code owners September 27, 2024 10:05
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.

Project coverage is 37.18%. Comparing base (91021c9) to head (61e2904).

Files with missing lines Patch % Lines
editoast/editoast_osrdyne_client/src/lib.rs 0.00% 20 Missing ⚠️
osrdyne/src/api.rs 0.00% 17 Missing ⚠️
osrdyne/src/status_tracker.rs 0.00% 9 Missing ⚠️
osrdyne/src/pool.rs 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9041      +/-   ##
============================================
- Coverage     37.19%   37.18%   -0.01%     
  Complexity     2242     2242              
============================================
  Files          1263     1263              
  Lines        116087   116099      +12     
  Branches       3278     3278              
============================================
- Hits          43174    43172       -2     
- Misses        70959    70973      +14     
  Partials       1954     1954              
Flag Coverage Δ
core 74.80% <ø> (ø)
editoast 72.30% <0.00%> (-0.03%) ⬇️
front 15.29% <ø> (ø)
gateway 2.22% <ø> (ø)
osrdyne 2.56% <0.00%> (-0.01%) ⬇️
railjson_generator 87.49% <ø> (ø)
tests 86.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put a description in the PR, I'm not entirely sure I understand what this is supposed to fix (is there any existing bug? why did the API changed? etc.)

@Khoyo
Copy link
Contributor Author

Khoyo commented Sep 30, 2024

is there any existing bug

Yes, the multi infra endpoint simply did not work (which is the reason for the request change on editoast side) :/

And we didn't support the case where there is multiple workers per key, which is coming soon with the work on using Keda, so I changed up the api a bit (we now return a map indexed by worker id, not worker key - except in the noop case where we have to make stuff up anyway)

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanations. Looks good.

Copy link
Contributor

@younesschrifi younesschrifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@Khoyo Khoyo enabled auto-merge October 1, 2024 13:15
@Khoyo Khoyo disabled auto-merge October 1, 2024 13:15
Signed-off-by: Younes Khoudli <younes.khoudli@epita.fr>
@Khoyo Khoyo enabled auto-merge October 1, 2024 18:00
@Khoyo Khoyo added this pull request to the merge queue Oct 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2024
@Khoyo Khoyo added this pull request to the merge queue Oct 1, 2024
Merged via the queue into dev with commit 9af72c2 Oct 1, 2024
24 checks passed
@Khoyo Khoyo deleted the yk/worker-status-list branch October 1, 2024 22:26
@Khoyo Khoyo self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants