Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix stop types in stdcm table results and simulation report sheet #9098

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

Akctarus
Copy link
Contributor

closes #9097

@Akctarus Akctarus requested a review from a team as a code owner September 27, 2024 13:54
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 139 lines in your changes missing coverage. Please review.

Project coverage is 38.48%. Comparing base (f1b814e) to head (0ba2bd9).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
...cations/stdcm/components/SimulationReportSheet.tsx 0.00% 76 Missing ⚠️
...ons/stdcm/components/SimulationReportStyleSheet.ts 0.00% 37 Missing ⚠️
.../src/applications/stdcmV2/components/StdcmVias.tsx 0.00% 15 Missing ⚠️
...cmV2/components/StdcmResults/StdcmResultsTable.tsx 0.00% 11 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9098      +/-   ##
============================================
- Coverage     38.52%   38.48%   -0.04%     
  Complexity     2244     2244              
============================================
  Files          1287     1287              
  Lines         97977    98037      +60     
  Branches       3256     3256              
============================================
- Hits          37746    37730      -16     
- Misses        58300    58376      +76     
  Partials       1931     1931              
Flag Coverage Δ
core 74.78% <ø> (ø)
editoast 71.93% <ø> (-0.06%) ⬇️
front 10.19% <0.00%> (-0.02%) ⬇️
gateway 2.22% <ø> (ø)
osrdyne 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/front/fix-stdcm-stop-types branch from 4e1537c to 34f292b Compare October 1, 2024 08:31
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested !!!

@Akctarus Akctarus force-pushed the tmn/front/fix-stdcm-stop-types branch from bf417a4 to 4e3d8e8 Compare October 2, 2024 13:15
@Akctarus Akctarus force-pushed the tmn/front/fix-stdcm-stop-types branch from 4e3d8e8 to 7125a34 Compare October 9, 2024 08:09
@Akctarus Akctarus force-pushed the tmn/front/fix-stdcm-stop-types branch from 1260d25 to b7d4193 Compare October 10, 2024 09:09
Signed-off-by: Theo Macron <theo.macron0315@gmail.com>
@Akctarus Akctarus force-pushed the tmn/front/fix-stdcm-stop-types branch from b7d4193 to 0ba2bd9 Compare October 10, 2024 09:13
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Akctarus Akctarus added this pull request to the merge queue Oct 10, 2024
Merged via the queue into dev with commit dd0833f Oct 10, 2024
24 checks passed
@Akctarus Akctarus deleted the tmn/front/fix-stdcm-stop-types branch October 10, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STDCM new interface : some stop types bugs
4 participants