Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add moon logo when the train passes after midnight #9111

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

theocrsb
Copy link
Contributor

closes #9104

@theocrsb theocrsb requested a review from a team as a code owner September 30, 2024 13:14
@theocrsb theocrsb changed the title front: add moon logo when the train passes after midnight add moon logo when the train passes after midnight Sep 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 37.15%. Comparing base (c8d96e7) to head (a5b77b7).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
...hedule/components/Timetable/TimetableTrainCard.tsx 0.00% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9111      +/-   ##
============================================
- Coverage     37.16%   37.15%   -0.01%     
  Complexity     2242     2242              
============================================
  Files          1262     1262              
  Lines        115862   115868       +6     
  Branches       3278     3278              
============================================
- Hits          43060    43055       -5     
- Misses        70848    70859      +11     
  Partials       1954     1954              
Flag Coverage Δ
core 74.80% <ø> (ø)
editoast 72.53% <ø> (-0.02%) ⬇️
front 15.19% <0.00%> (-0.01%) ⬇️
gateway 2.22% <ø> (ø)
osrdyne 2.56% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, feel free to resolve conversations!

Signed-off-by: theocrsb <theo_crosbie@yahoo.fr>
@theocrsb theocrsb force-pushed the tce/front/trainschedule/add-moon-logo branch from 9d9774c to a5b77b7 Compare October 1, 2024 14:35
@theocrsb theocrsb added this pull request to the merge queue Oct 1, 2024
Merged via the queue into dev with commit 78160a2 Oct 1, 2024
23 checks passed
@theocrsb theocrsb deleted the tce/front/trainschedule/add-moon-logo branch October 1, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add moon logo when train past midnight on list of trains
4 participants