front: nuke storybook #9147
Merged
front: nuke storybook #9147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
emr/upgrade-storybook
branch
2 times, most recently
from
92de157
to
c706127
Compare
Khoyo
approved these changes
Oct 2, 2024
emersion
force-pushed
the
emr/upgrade-storybook
branch
2 times, most recently
from
8b137a4
to
8e17f04
Compare
emersion
force-pushed
the
emr/upgrade-storybook
branch
from
8e17f04
to
3c75104
Compare
github-actions
bot
added
area:front
kmer2016
reviewed
Oct 3, 2024
emersion
force-pushed
the
emr/upgrade-storybook
branch
from
3c75104
to
11d9cea
Compare
kmer2016
approved these changes
Oct 4, 2024
Without dotenv the build fails. We were installing dotenv by chance
via storybook, but we'll drop that one in the next commit.
#50 2.679 $ vite build
#50 2.864 failed to load config from /app/vite.config.mts
#50 2.864 error during build:
#50 2.864 Error: Cannot find module 'dotenv'
#50 2.864 Require stack:
#50 2.864 - /app/node_modules/@import-meta-env/unplugin/dist/index.js
#50 2.864 at Module._resolveFilename (node:internal/modules/cjs/loader:1225:15)
#50 2.864 at Module._load (node:internal/modules/cjs/loader:1051:27)
#50 2.864 at Module.require (node:internal/modules/cjs/loader:1311:19)
#50 2.864 at require (node:internal/modules/helpers:179:18)
#50 2.864 at Object.<anonymous> (/app/node_modules/@import-meta-env/unplugin/dist/index.js:107:22)
#50 2.864 at Module._compile (node:internal/modules/cjs/loader:1469:14)
#50 2.864 at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
#50 2.864 at Module.load (node:internal/modules/cjs/loader:1288:32)
#50 2.864 at Module._load (node:internal/modules/cjs/loader:1104:12)
#50 2.864 at cjsLoader (node:internal/modules/esm/translators:346:17)
Signed-off-by: Simon Ser <contact@emersion.fr>
This is badly outdated and we never use it in practice. It's easier to just directly test the components within the app. Signed-off-by: Simon Ser <contact@emersion.fr>
emersion
force-pushed
the
emr/upgrade-storybook
branch
from
11d9cea
to
87963bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is badly outdated and we never use it in practice. It's easier to just directly test the components within the app.