Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the invalid train card to the timetable and delete the old one #9152

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

theocrsb
Copy link
Contributor

@theocrsb theocrsb commented Oct 2, 2024

Closes part of this ticket.

@theocrsb theocrsb requested a review from a team as a code owner October 2, 2024 09:48
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 37.22%. Comparing base (bfa0065) to head (1983ef6).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...schedule/components/Timetable/TimetableToolbar.tsx 0.00% 10 Missing ⚠️
...s/trainschedule/components/Timetable/Timetable.tsx 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9152      +/-   ##
============================================
- Coverage     37.22%   37.22%   -0.01%     
  Complexity     2242     2242              
============================================
  Files          1265     1265              
  Lines        116360   116360              
  Branches       3280     3280              
============================================
- Hits          43318    43314       -4     
- Misses        71087    71091       +4     
  Partials       1955     1955              
Flag Coverage Δ
core 74.78% <ø> (ø)
editoast 72.09% <ø> (-0.02%) ⬇️
front 15.33% <0.00%> (ø)
gateway 2.22% <ø> (ø)
osrdyne 2.56% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM, just to be pixel perfect, the grey border-bottom that we have in .scenario-timetable-toolbar should be a border-top in .filter, but it's not directly linked to this PR

@theocrsb
Copy link
Contributor Author

theocrsb commented Oct 2, 2024

Tested, LGTM, just to be pixel perfect, the grey border-bottom that we have in .scenario-timetable-toolbar should be a border-top in .filter, but it's not directly linked to this PR

Done

@theocrsb theocrsb requested a review from Akctarus October 2, 2024 11:08
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

Signed-off-by: theocrsb <theo_crosbie@yahoo.fr>
@theocrsb theocrsb force-pushed the tce/front/trainschedule/timetable-with-invalid-train branch from fa4f422 to 1983ef6 Compare October 3, 2024 06:19
@theocrsb theocrsb added this pull request to the merge queue Oct 3, 2024
Merged via the queue into dev with commit 2a70df7 Oct 3, 2024
24 checks passed
@theocrsb theocrsb deleted the tce/front/trainschedule/timetable-with-invalid-train branch October 3, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants