-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the invalid train card to the timetable and delete the old one #9152
add the invalid train card to the timetable and delete the old one #9152
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9152 +/- ##
============================================
- Coverage 37.22% 37.22% -0.01%
Complexity 2242 2242
============================================
Files 1265 1265
Lines 116360 116360
Branches 3280 3280
============================================
- Hits 43318 43314 -4
- Misses 71087 71091 +4
Partials 1955 1955
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM, just to be pixel perfect, the grey border-bottom that we have in .scenario-timetable-toolbar should be a border-top in .filter, but it's not directly linked to this PR
Done |
front/src/styles/scss/applications/operationalStudies/_scenario.scss
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested
Signed-off-by: theocrsb <theo_crosbie@yahoo.fr>
fa4f422
to
1983ef6
Compare
Closes part of this ticket.