-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove application roles #9157
Remove application roles #9157
Conversation
9f3ae67
to
62c2814
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9157 +/- ##
============================================
- Coverage 37.22% 37.15% -0.07%
Complexity 2242 2242
============================================
Files 1265 1265
Lines 116356 116174 -182
Branches 3279 3280 +1
============================================
- Hits 43315 43166 -149
+ Misses 71087 71053 -34
- Partials 1954 1955 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
82b27c8
to
681a34d
Compare
Shouldn't it rather be named Or maybe something more explicit, like |
…flag Signed-off-by: Leo Valais <leo.valais97@gmail.com>
They will be added back with another implementation when we'll have an admin panel where admins will be able to configure them. Signed-off-by: Leo Valais <leo.valais97@gmail.com>
Signed-off-by: Leo Valais <leo.valais97@gmail.com>
Signed-off-by: Leo Valais <leo.valais97@gmail.com>
681a34d
to
21b7e98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! 🙏
Follow up #8984
Tip
Review commits individually.
Superuser
builtin role--superuser
cmd flagRoleConfig