-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: switch from yarn to npm #9169
base: dev
Are you sure you want to change the base?
Conversation
0845e2d
to
068566f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9169 +/- ##
===========================================
+ Coverage 37.82% 91.14% +53.32%
===========================================
Files 994 773 -221
Lines 91103 82300 -8803
Branches 1176 1168 -8
===========================================
+ Hits 34459 75015 +40556
+ Misses 56190 7248 -48942
+ Partials 454 37 -417
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
I had success running https://github.com/imsnif/synp I think we'd be less likely to run into issues if we can use this tool instead of crossing fingers. |
f93eaa3
to
01593dc
Compare
fd7c55e
to
6e85906
Compare
a351913
to
4ef8616
Compare
|
fe429c1
to
32d76db
Compare
Signed-off-by: Yohh <durandyohan@zaclys.net>
32d76db
to
cb4fea5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the README update
front/package.json
Outdated
@@ -125,7 +126,7 @@ | |||
"@vitejs/plugin-react-swc": "^3.6.0", | |||
"@vitest/coverage-v8": "^2.0.0", | |||
"dotenv": "^16.4.5", | |||
"eslint": "^8.56.0", | |||
"eslint": "^8.57.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, why did the version constraints in package.json
change? I'd expect the package.json
to stay as-is except for the overrides
rename.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, unless I'm missing something, I still see these package.json
changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure your branch is up to date? I don"t see it anymore...
edit: ok I missed some packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
The dependency in the lockfile is probably valid, the rest probably isn't. |
you're right, I removed the useless mentions in |
d622b9c
to
487659a
Compare
The |
487659a
to
ee40939
Compare
close #9143