Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add logo when train is projected #9192

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

theocrsb
Copy link
Contributor

@theocrsb theocrsb commented Oct 4, 2024

This PR needs this ticket to be finished
closes #9191

@theocrsb theocrsb requested a review from a team as a code owner October 4, 2024 06:35
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 39.15%. Comparing base (3ac680e) to head (fe79549).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...s/trainschedule/components/Timetable/Timetable.tsx 0.00% 5 Missing ⚠️
...hedule/components/Timetable/TimetableTrainCard.tsx 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9192      +/-   ##
============================================
- Coverage     39.16%   39.15%   -0.02%     
  Complexity     2245     2245              
============================================
  Files          1290     1290              
  Lines         97268    97277       +9     
  Branches       3280     3280              
============================================
- Hits          38097    38088       -9     
- Misses        57232    57250      +18     
  Partials       1939     1939              
Flag Coverage Δ
core 74.94% <ø> (ø)
editoast 72.46% <ø> (-0.04%) ⬇️
front 10.33% <0.00%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
osrdyne 3.52% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theocrsb theocrsb force-pushed the tce/front/trainschedule/add-logo-train-projected branch from 52466c4 to dc0b104 Compare October 7, 2024 17:13
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Math-R Math-R self-requested a review October 8, 2024 11:22
@theocrsb theocrsb force-pushed the tce/front/trainschedule/add-logo-train-projected branch 2 times, most recently from bbdfd03 to 1490fbc Compare October 10, 2024 12:17
Copy link
Contributor

@RomainValls RomainValls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, tested 👍

@theocrsb theocrsb added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
Signed-off-by: theocrsb <theo_crosbie@yahoo.fr>
@theocrsb theocrsb force-pushed the tce/front/trainschedule/add-logo-train-projected branch from 1490fbc to fe79549 Compare October 14, 2024 12:23
@theocrsb theocrsb added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@theocrsb theocrsb added this pull request to the merge queue Oct 14, 2024
Merged via the queue into dev with commit a815c8a Oct 14, 2024
24 checks passed
@theocrsb theocrsb deleted the tce/front/trainschedule/add-logo-train-projected branch October 14, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an icon when a train is projected
4 participants