Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osrdyne: change policy to match all queues #9193

Closed
wants to merge 1 commit into from

Conversation

ElysaSrc
Copy link
Member

@ElysaSrc ElysaSrc commented Oct 4, 2024

No description provided.

@ElysaSrc ElysaSrc requested a review from a team as a code owner October 4, 2024 08:07
Signed-off-by: ElysaSrc <101974839+ElysaSrc@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 37.53%. Comparing base (b123aef) to head (5797704).
Report is 12 commits behind head on dev.

Files with missing lines Patch % Lines
osrdyne/src/pool.rs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9193      +/-   ##
============================================
- Coverage     37.53%   37.53%   -0.01%     
  Complexity     2242     2242              
============================================
  Files          1256     1256              
  Lines        114937   114937              
  Branches       3271     3271              
============================================
- Hits          43143    43142       -1     
- Misses        69848    69849       +1     
  Partials       1946     1946              
Flag Coverage Δ
core 74.78% <ø> (ø)
editoast 72.05% <ø> (-0.01%) ⬇️
front 15.57% <ø> (ø)
gateway 2.22% <ø> (ø)
osrdyne 2.56% <0.00%> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElysaSrc
Copy link
Member Author

ElysaSrc commented Oct 4, 2024

We're not compltetly sure this change is required in any way, closing it for now.

@ElysaSrc ElysaSrc closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants