front: add op simulation settings e2e test #9216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maymanaf
force-pushed
the
aba/e2e-op-simulation-settings
branch
5 times, most recently
from
f81f2f4
to
917f1e6
Compare
Maymanaf
force-pushed
the
aba/e2e-op-simulation-settings
branch
from
917f1e6
to
3e4291f
Compare
Yohh
reviewed
Oct 9, 2024
Yohh
reviewed
Oct 9, 2024
Yohh
reviewed
Oct 9, 2024
|
hard to test... every try leads to timeout at |
Maymanaf
force-pushed
the
aba/e2e-op-simulation-settings
branch
4 times, most recently
from
2d47d2e
to
5d0e2ca
Compare
SharglutDev
reviewed
Oct 11, 2024
There was a problem hiding this comment.
Thank you for all these changes. Left some comments.
I also have the tests failing on arrivalTime (macOs Sequoia too). We expect to see for example 12:05 but that's only what we choose to display to the user. In reality, the arrival time is a dateTime string. See below screen when hovering the arrival time. Could the failure come from that ?
front/tests/assets/operationStudies/simulationSettings/margin/marecoMargin.json
Outdated
Show resolved
Hide resolved
Maymanaf
force-pushed
the
aba/e2e-op-simulation-settings
branch
6 times, most recently
from
7875311
to
2ceef12
Compare
SharglutDev
approved these changes
Oct 15, 2024
Maymanaf
force-pushed
the
aba/e2e-op-simulation-settings
branch
from
2ceef12
to
8d34bad
Compare
Maymanaf
force-pushed
the
aba/e2e-op-simulation-settings
branch
from
8d34bad
to
8e564ea
Compare
Signed-off-by: maymanaf <med.aymen.naf@gmail.com>
Maymanaf
force-pushed
the
aba/e2e-op-simulation-settings
branch
from
8e564ea
to
9218e32
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9239
Closes #9240
Closes #9241
Closes #9243
Requires #8854 and #9180 to be resolved