Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: import test functions from vitest in every test file #9264

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

Yohh
Copy link
Contributor

@Yohh Yohh commented Oct 9, 2024

close #9263

@Yohh Yohh requested a review from a team as a code owner October 9, 2024 09:24
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.57%. Comparing base (e0152b0) to head (edcb821).
Report is 20 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9264      +/-   ##
============================================
+ Coverage     36.91%   38.57%   +1.65%     
  Complexity     2242     2242              
============================================
  Files          1255     1285      +30     
  Lines        116958    97803   -19155     
  Branches       3270     3254      -16     
============================================
- Hits          43178    37724    -5454     
+ Misses        71835    58150   -13685     
+ Partials       1945     1929      -16     
Flag Coverage Δ
core 74.78% <ø> (ø)
editoast 72.22% <ø> (-0.05%) ⬇️
front 10.22% <ø> (-5.40%) ⬇️
gateway 2.22% <ø> (ø)
osrdyne 2.46% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yohh Yohh force-pushed the yoh/front-fix-test-functions-import branch from a54b1fb to 2df9f38 Compare October 9, 2024 09:27
@emersion
Copy link
Member

emersion commented Oct 9, 2024

While at it can we remove the vitest globals: true option?

Signed-off-by: Yohh <durandyohan@zaclys.net>
@Yohh Yohh force-pushed the yoh/front-fix-test-functions-import branch from 2df9f38 to edcb821 Compare October 9, 2024 09:56
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Oct 9, 2024
@Yohh
Copy link
Contributor Author

Yohh commented Oct 9, 2024

While at it can we remove the vitest globals: true option?

done, this showed me that I missed some functions

Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@Yohh Yohh added this pull request to the merge queue Oct 9, 2024
Merged via the queue into dev with commit 9d2652d Oct 9, 2024
24 checks passed
@Yohh Yohh deleted the yoh/front-fix-test-functions-import branch October 9, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: import every missing test functions
4 participants