Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add short slip safety speed to buffer stops #9300

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Oct 10, 2024

Fix #9283

@eckter eckter requested a review from bougue-pe October 10, 2024 14:43
@eckter eckter requested a review from a team as a code owner October 10, 2024 14:43
@eckter eckter requested a review from Khoyo October 10, 2024 14:43
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 38.55%. Comparing base (b38f9e2) to head (1277ef6).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
...in/java/fr/sncf/osrd/standalone_sim/SafetySpeed.kt 85.00% 1 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9300      +/-   ##
============================================
+ Coverage     38.45%   38.55%   +0.10%     
- Complexity     2244     2245       +1     
============================================
  Files          1288     1288              
  Lines         98429    98470      +41     
  Branches       3273     3276       +3     
============================================
+ Hits          37855    37970     +115     
+ Misses        58637    58561      -76     
- Partials       1937     1939       +2     
Flag Coverage Δ
core 74.98% <85.00%> (+0.10%) ⬆️
editoast 72.39% <ø> (+0.30%) ⬆️
front 10.13% <ø> (-0.01%) ⬇️
gateway 2.19% <ø> (ø)
osrdyne 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter force-pushed the ech/safety-speed-buffer-stop branch from 882880d to d39afdd Compare October 10, 2024 15:11
Signed-off-by: Eloi Charpentier <eloi.charpentier.42@gmail.com>
@eckter eckter force-pushed the ech/safety-speed-buffer-stop branch from d39afdd to 1277ef6 Compare October 11, 2024 07:54
Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the digging on that!

@eckter eckter added this pull request to the merge queue Oct 11, 2024
Merged via the queue into dev with commit c38240a Oct 11, 2024
24 checks passed
@eckter eckter deleted the ech/safety-speed-buffer-stop branch October 11, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: safety-speed: add safety speed ranges before buffer stops
4 participants