-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdcm: towed rolling stock parameter #9383
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9383 +/- ##
============================================
+ Coverage 39.66% 39.79% +0.12%
Complexity 2270 2270
============================================
Files 1300 1302 +2
Lines 99029 99492 +463
Branches 3279 3282 +3
============================================
+ Hits 39284 39589 +305
- Misses 57816 57971 +155
- Partials 1929 1932 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
005a354
to
b2901ec
Compare
852257f
to
a37e4e7
Compare
25d0dd7
to
8d29b58
Compare
d507af5
to
da54a6f
Compare
8184487
to
50b6a35
Compare
front/src/applications/stdcm/hooks/useStdcmTowedRollingStock.ts
Outdated
Show resolved
Hide resolved
248ffab
to
35170f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, great job !
35170f3
to
fbc6a8c
Compare
Signed-off-by: Egor Berezovskiy <egor@berezify.fr>
fbc6a8c
to
6f976ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only checked the physics part and the tests but LGTM !
A few suggestions but that do not request immediate changes imo (just make sure that the front end will ensure the minimum value of mass / length).
It would be great to comment all the units of the test values in another PR though.
part of https://github.com/osrd-project/osrd-confidential/issues/368