Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: change call arguments for shutting down the docker #9426

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

EthanPERRUZZA
Copy link
Contributor

@EthanPERRUZZA EthanPERRUZZA commented Oct 22, 2024

I hadn't see that PE wanted those changes on the script rework too OpenRailAssociation/osrd-website#247

\ + fix help not showing on certain cases

… not showing on certain cases

Signed-off-by: Ethan Perruzza <ethan.perruzza@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.07%. Comparing base (f79e009) to head (7cc270b).
Report is 20 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #9426   +/-   ##
=========================================
  Coverage     39.07%   39.07%           
  Complexity     2267     2267           
=========================================
  Files          1308     1308           
  Lines         99202    99202           
  Branches       3312     3312           
=========================================
+ Hits          38765    38766    +1     
+ Misses        58474    58473    -1     
  Partials       1963     1963           
Flag Coverage Δ
core 74.93% <ø> (ø)
editoast 71.99% <ø> (+<0.01%) ⬆️
front 10.33% <ø> (ø)
gateway 2.50% <ø> (ø)
osrdyne 3.29% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EthanPERRUZZA EthanPERRUZZA marked this pull request as ready for review October 23, 2024 15:06
@EthanPERRUZZA EthanPERRUZZA self-assigned this Oct 23, 2024
@EthanPERRUZZA EthanPERRUZZA requested review from woshilapin and bougue-pe and removed request for woshilapin October 23, 2024 15:07
Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it already worked with or without it 🤭
It was not mandatory, yet, thanks for this !

@EthanPERRUZZA EthanPERRUZZA added this pull request to the merge queue Oct 24, 2024
Merged via the queue into dev with commit ac372ac Oct 24, 2024
24 checks passed
@EthanPERRUZZA EthanPERRUZZA deleted the eth/pr-test-mac branch October 24, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants