Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemas: fix towed rolling stock structure #9436

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

woshilapin
Copy link
Contributor

Seems like it was missed during the work on #9202, the schema was actually some sort of copy of RollingStock, but modifications were not done... 🤦

@woshilapin woshilapin requested a review from a team as a code owner October 23, 2024 13:45
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.07%. Comparing base (f7d17ed) to head (c7a7d26).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9436      +/-   ##
============================================
- Coverage     39.07%   39.07%   -0.01%     
  Complexity     2270     2270              
============================================
  Files          1308     1308              
  Lines         99249    99249              
  Branches       3315     3315              
============================================
- Hits          38786    38777       -9     
- Misses        58499    58508       +9     
  Partials       1964     1964              
Flag Coverage Δ
core 74.99% <ø> (ø)
editoast 71.98% <ø> (-0.04%) ⬇️
front 10.32% <ø> (ø)
gateway 2.50% <ø> (ø)
osrdyne 3.29% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, indeed, good catch 👀

Copy link
Contributor

@EthanPERRUZZA EthanPERRUZZA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have add some kind of comment somewhere (maybe on this PR?) to know why we moved to NonNegativeFloat here and not above.
Or it might be worth to also substitute the occurences of PositiveFloat above as it shouldn't have any impact and will make the code more harmonious.
Otherwise, LGTM

python/osrd_schemas/osrd_schemas/rolling_stock.py Outdated Show resolved Hide resolved
Signed-off-by: Jean SIMARD <woshilapin@tuziwo.info>
@woshilapin woshilapin added this pull request to the merge queue Oct 23, 2024
Merged via the queue into dev with commit 8c03cbf Oct 23, 2024
24 checks passed
@woshilapin woshilapin deleted the wsl/osrd_schemas/fix-towed branch October 23, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants