-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schemas: fix towed rolling stock structure #9436
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9436 +/- ##
============================================
- Coverage 39.07% 39.07% -0.01%
Complexity 2270 2270
============================================
Files 1308 1308
Lines 99249 99249
Branches 3315 3315
============================================
- Hits 38786 38777 -9
- Misses 58499 58508 +9
Partials 1964 1964
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, indeed, good catch 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have add some kind of comment somewhere (maybe on this PR?) to know why we moved to NonNegativeFloat here and not above.
Or it might be worth to also substitute the occurences of PositiveFloat above as it shouldn't have any impact and will make the code more harmonious.
Otherwise, LGTM
e3665de
to
2f39d22
Compare
Signed-off-by: Jean SIMARD <woshilapin@tuziwo.info>
2f39d22
to
c7a7d26
Compare
Seems like it was missed during the work on #9202, the schema was actually some sort of copy of
RollingStock
, but modifications were not done... 🤦