Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowners to script repo #9438

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Add codeowners to script repo #9438

merged 1 commit into from
Oct 24, 2024

Conversation

EthanPERRUZZA
Copy link
Contributor

Making a change in a script, I realized I was able to merge my changes without any review.

I would say that scripts are under the responsibility of the devops team, hence this PR.

@github-actions github-actions bot added the area:ci Work on Continous Integration Pipeline Service label Oct 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.06%. Comparing base (f0ab6fa) to head (403c7d2).
Report is 20 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9438      +/-   ##
============================================
- Coverage     39.08%   39.06%   -0.03%     
  Complexity     2270     2270              
============================================
  Files          1308     1308              
  Lines         99220    99317      +97     
  Branches       3315     3316       +1     
============================================
+ Hits          38785    38794       +9     
- Misses        58471    58558      +87     
- Partials       1964     1965       +1     
Flag Coverage Δ
core 74.99% <ø> (+<0.01%) ⬆️
editoast 71.88% <ø> (-0.14%) ⬇️
front 10.32% <ø> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
osrdyne 3.29% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EthanPERRUZZA EthanPERRUZZA marked this pull request as ready for review October 24, 2024 07:46
@EthanPERRUZZA EthanPERRUZZA requested a review from a team as a code owner October 24, 2024 07:46
Signed-off-by: Ethan Perruzza <ethan.perruzza@gmail.com>
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@EthanPERRUZZA EthanPERRUZZA added this pull request to the merge queue Oct 24, 2024
Merged via the queue into dev with commit ca24f44 Oct 24, 2024
24 checks passed
@EthanPERRUZZA EthanPERRUZZA deleted the eth/add_script_codeowner branch October 24, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ci Work on Continous Integration Pipeline Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants