Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix stdcm passage #9653

Merged
merged 1 commit into from
Nov 22, 2024
Merged

front: fix stdcm passage #9653

merged 1 commit into from
Nov 22, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Nov 8, 2024

closes #9655

@clarani clarani requested a review from a team as a code owner November 8, 2024 09:32
@clarani clarani changed the title front: fix workschedule projection and passage front: fix workschedules projection and passage Nov 8, 2024
@clarani clarani requested a review from bloussou November 8, 2024 09:32
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 37.80%. Comparing base (57c96f7) to head (1328511).
Report is 17 commits behind head on dev.

Files with missing lines Patch % Lines
...nt/src/applications/stdcm/utils/formatStdcmConf.ts 0.00% 19 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9653      +/-   ##
==========================================
- Coverage   37.82%   37.80%   -0.03%     
==========================================
  Files         994      994              
  Lines       91126    91171      +45     
  Branches     1176     1176              
==========================================
- Hits        34466    34463       -3     
- Misses      56206    56254      +48     
  Partials      454      454              
Flag Coverage Δ
editoast 72.98% <ø> (-0.03%) ⬇️
front 20.10% <0.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@emersion
Copy link
Member

emersion commented Nov 8, 2024

Ouch :/ would it really be that much work to fix in editoast instead?

@clarani
Copy link
Contributor Author

clarani commented Nov 8, 2024

Right now, we just need a valid image so @bloussou can deploy on prod :/ I can ask on Element if someone can fix the bug in editoast

@emersion
Copy link
Member

emersion commented Nov 8, 2024

Alternative fix for the first commit (edit: that commit has now been dropped): #9656

@clarani clarani changed the title front: fix workschedules projection and passage front: fix stdcm passage Nov 12, 2024
@clarani
Copy link
Contributor Author

clarani commented Nov 12, 2024

I removed the last commit, related to the work schedules

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, but got this error message: Last step of stdcm request needs to be a stop

last step duration is equal to undefined, and the request fails because of this. We'd have to add a duration = 0 to this step

@clarani
Copy link
Contributor Author

clarani commented Nov 20, 2024

You're right, it's fixed

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM !

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested !

@clarani clarani added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@clarani clarani added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@clarani clarani added this pull request to the merge queue Nov 21, 2024
@clarani clarani removed this pull request from the merge queue due to a manual request Nov 21, 2024
@clarani clarani force-pushed the cni/fix-stdcm branch 2 times, most recently from 93650c3 to 0c7b9db Compare November 22, 2024 08:30
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 22, 2024
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani clarani added this pull request to the merge queue Nov 22, 2024
Merged via the queue into dev with commit 28c965c Nov 22, 2024
27 checks passed
@clarani clarani deleted the cni/fix-stdcm branch November 22, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: stdcm stops at all vias, even if they are only "passage"
5 participants