-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix stdcm passage #9653
front: fix stdcm passage #9653
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9653 +/- ##
==========================================
- Coverage 37.82% 37.80% -0.03%
==========================================
Files 994 994
Lines 91126 91171 +45
Branches 1176 1176
==========================================
- Hits 34466 34463 -3
- Misses 56206 56254 +48
Partials 454 454
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Ouch :/ would it really be that much work to fix in editoast instead? |
21290bd
to
5b23f00
Compare
Right now, we just need a valid image so @bloussou can deploy on prod :/ I can ask on Element if someone can fix the bug in editoast |
Alternative fix for the first commit (edit: that commit has now been dropped): #9656 |
5b23f00
to
3a7ef0c
Compare
I removed the last commit, related to the work schedules |
3a7ef0c
to
87a4c47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, but got this error message: Last step of stdcm request needs to be a stop
last step duration is equal to undefined
, and the request fails because of this. We'd have to add a duration = 0
to this step
87a4c47
to
6337fd7
Compare
You're right, it's fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested !
6337fd7
to
b569b9c
Compare
93650c3
to
0c7b9db
Compare
0c7b9db
to
9e29593
Compare
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
9e29593
to
1328511
Compare
closes #9655