front: fix row deletion in timestop input table

[Synar]

Partial fix of #8959
-> IV. Multi selected fields modification is bugged
-> V. Delete the value of a stopping time field behaves weirdly

Prevents deletion of empty fields from creating a via

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 35.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 37.78%. Comparing base (8a2b4c9) to head (f584878).
Report is 63 commits behind head on dev.

Files with missing lines	Patch %	Lines
front/src/modules/timesStops/helpers/utils.ts	41.17%	10 Missing ⚠️
front/src/modules/timesStops/TimesStopsInput.tsx	0.00%	3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #9739      +/-   ##
==========================================
- Coverage   37.85%   37.78%   -0.07%     
==========================================
  Files         990      994       +4     
  Lines       90921    91210     +289     
  Branches     1176     1178       +2     
==========================================
+ Hits        34415    34462      +47     
- Misses      56052    56294     +242     
  Partials      454      454              

Flag	Coverage Δ
editoast	72.97% <ø> (-0.32%)	⬇️
front	20.09% <35.00%> (-0.02%)	⬇️
gateway	2.18% <ø> (ø)
osrdyne	3.28% <ø> (ø)
railjson_generator	87.49% <ø> (ø)
tests	86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[louisgreiner]

Working perfectly, thanks !

[emersion]

Hm, I must admit I'm not a huge fan of this workaround. Could we instead fix the function which checks whether two rows are equal, to consider that null is equivalent to undefined?

[Synar]

Hm, I must admit I'm not a huge fan of this workaround. Could we instead fix the function which checks whether two rows are equal, to consider that null is equivalent to undefined?

Right now we're just using lodash isEqual. I suppose we could call a normalizing function setting null to undefined (or both to false for stopSignal) on both rows before comparing. Would you prefer that?

[emersion]

We could do something like:

const { stopFor, theoreticalMargin, ...rest } = row;
return isEqual(rest, …) && stopFor == … && theoreticalMargin == …;

Normalizing sounds fine to me as well.

[emersion]

Another upside of normalizing is that we can stick to === so we don't need to think about the weird rules of ==.

[kmer2016]

LGTM !

[emersion]

Nit: does this change really matter? If we reset the field to false when it's already false, it's a no-op so should be fine as well?

(In general, I prefer keeping the list of conditions in a if as small as possible.)

[Synar]

It does because we also set null/undefined to false, which means we need to add the row to the path to remember it.

We could also put it in the format function, but here I think it makes more sense to directly avoid doing a modification rather than do it then drop it after the comparison