Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use microsoft playwright image in e2e tests #9741

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Nov 16, 2024

Close #9738

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.78%. Comparing base (8a2b4c9) to head (62fefc8).
Report is 64 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9741      +/-   ##
==========================================
- Coverage   37.85%   37.78%   -0.08%     
==========================================
  Files         990      994       +4     
  Lines       90921    91185     +264     
  Branches     1176     1174       -2     
==========================================
+ Hits        34415    34450      +35     
- Misses      56052    56281     +229     
  Partials      454      454              
Flag Coverage Δ
editoast 72.96% <ø> (-0.32%) ⬇️
front 20.08% <ø> (-0.04%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Synar
Copy link
Contributor Author

Synar commented Nov 16, 2024

Before the changes, the playwright installation took 120s to 140s on 3 attempts.
After the changes, out of 3 attempts, all took 80s to 82s.
We will attempt a second speed up, by reusing the test-front image to multistage build the playwright image.

@Synar Synar force-pushed the ali/use-microsoft-playwright-image-in-ci-e2e-tests branch 14 times, most recently from 7509f30 to ec67894 Compare November 17, 2024 00:57
@Synar
Copy link
Contributor Author

Synar commented Nov 17, 2024

Sadly the multistage approach does not appear to be any faster

The second "fixup" is thus likely to be dropped

@Synar Synar marked this pull request as ready for review November 17, 2024 08:46
@Synar Synar requested review from a team as code owners November 17, 2024 08:46
.github/workflows/build.yml Outdated Show resolved Hide resolved
front/docker/Dockerfile.playwright-ci Outdated Show resolved Hide resolved
@github-actions github-actions bot added area:front Work on Standard OSRD Interface modules area:ci Work on Continous Integration Pipeline Service labels Nov 22, 2024
@Synar Synar force-pushed the ali/use-microsoft-playwright-image-in-ci-e2e-tests branch from 68767c4 to 06351cd Compare November 22, 2024 16:33
@github-actions github-actions bot removed the area:front Work on Standard OSRD Interface modules label Nov 22, 2024
Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
@Synar Synar force-pushed the ali/use-microsoft-playwright-image-in-ci-e2e-tests branch from 06351cd to 62fefc8 Compare November 22, 2024 16:43
@Khoyo Khoyo removed the request for review from a team November 22, 2024 17:31
@Synar Synar added this pull request to the merge queue Nov 22, 2024
Merged via the queue into dev with commit b4dd722 Nov 22, 2024
27 checks passed
@Synar Synar deleted the ali/use-microsoft-playwright-image-in-ci-e2e-tests branch November 22, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ci Work on Continous Integration Pipeline Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accelerate build time by using prebuilt playwright image to run end-to-end tests in the CI
3 participants