front: nge language synchro + Remove SBB header + bump NGE version 2.9.9 #9760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9760 +/- ##
==========================================
- Coverage 37.82% 37.80% -0.03%
==========================================
Files 994 994
Lines 91105 91147 +42
Branches 1176 1176
==========================================
- Hits 34463 34455 -8
- Misses 56188 56238 +50
Partials 454 454
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
louisgreiner
changed the title
louisgreiner
force-pushed
the
lgr/synchronize-osrd-nge-locale
branch
2 times, most recently
from
c82b079
to
8b08a08
Compare
louisgreiner
force-pushed
the
lgr/synchronize-osrd-nge-locale
branch
from
8b08a08
to
81ed0a8
Compare
Uriel-Sautron
approved these changes
Nov 20, 2024
SharglutDev
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Lgtm and tested, good job !
Maybe we can wait for @emersion or @flomonster approval for the license part to merge :)
emersion
reviewed
Nov 21, 2024
emersion
reviewed
Nov 21, 2024
louisgreiner
force-pushed
the
lgr/synchronize-osrd-nge-locale
branch
from
ac636b1
to
67d7793
Compare
Signed-off-by: Louis Greiner <greiner.louis@gmail.com>
louisgreiner
force-pushed
the
lgr/synchronize-osrd-nge-locale
branch
from
67d7793
to
b61f6a6
Compare
This was referenced Nov 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #9694
note to myself : remember to squash before merge