Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: refactor: renamed many structs for consistency #9810

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Nov 21, 2024

Part of #9724

Signed-off-by: hamz2a <atrari.hamza@gmail.com>
@hamz2a hamz2a requested a review from a team as a code owner November 21, 2024 14:38
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.81%. Comparing base (34a4f34) to head (b1dc53e).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9810      +/-   ##
==========================================
- Coverage   37.82%   37.81%   -0.01%     
==========================================
  Files         994      994              
  Lines       91126    91126              
  Branches     1176     1176              
==========================================
- Hits        34464    34462       -2     
- Misses      56208    56210       +2     
  Partials      454      454              
Flag Coverage Δ
editoast 72.99% <100.00%> (-0.01%) ⬇️
front 20.11% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hamz2a hamz2a added this pull request to the merge queue Nov 21, 2024
Merged via the queue into dev with commit 55e6e35 Nov 21, 2024
27 checks passed
@hamz2a hamz2a deleted the hai/editoast-renamed-many-structs-for-consistency branch November 21, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants