front: align compute margin to spec in timestops table #9823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synar
force-pushed
the
ali/align-compute-margin-to-spec-in-timestops-table
branch
from
0048fba
to
727c5e5
Compare
Synar
changed the title
Synar
force-pushed
the
ali/align-compute-margin-to-spec-in-timestops-table
branch
from
727c5e5
to
7046a03
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9823 +/- ##
==========================================
- Coverage 38.22% 38.21% -0.01%
==========================================
Files 995 995
Lines 91910 91954 +44
Branches 1193 1190 -3
==========================================
+ Hits 35128 35138 +10
- Misses 56327 56361 +34
Partials 455 455
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Synar
force-pushed
the
ali/align-compute-margin-to-spec-in-timestops-table
branch
from
7046a03
to
d7fd861
Compare
Synar
force-pushed
the
ali/align-compute-margin-to-spec-in-timestops-table
branch
5 times, most recently
from
b7f80a0
to
2fdc90f
Compare
clarani
reviewed
Nov 27, 2024
There was a problem hiding this comment.
Is this behavior normal ? Theoretical margin is bold for some PRs, but not bold for the rest of the PRs
Edit: yes it is ->
- bold : when user has forced
0%of margin - not bold : when the user did not set margin, but the PR is especially asked for the pathfinding
clarani
reviewed
Nov 27, 2024
louisgreiner
approved these changes
Nov 27, 2024
Synar
force-pushed
the
ali/align-compute-margin-to-spec-in-timestops-table
branch
3 times, most recently
from
98496c3
to
b08cc74
Compare
Maymanaf
reviewed
Nov 28, 2024
front/tests/assets/operationStudies/timesAndStops/expectedOutputsCellsData.json
Outdated
Show resolved
Hide resolved
Synar
force-pushed
the
ali/align-compute-margin-to-spec-in-timestops-table
branch
from
b08cc74
to
0e92d6e
Compare
Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
Synar
force-pushed
the
ali/align-compute-margin-to-spec-in-timestops-table
branch
from
0e92d6e
to
b323bd2
Compare
Synar
deleted the
ali/align-compute-margin-to-spec-in-timestops-table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #9737
Also partially fix #8959
Depend on #9642