-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: add speed space chart e2e test #9829
base: dev
Are you sure you want to change the base?
Conversation
7ce7004
to
fdc276e
Compare
fdc276e
to
6fbebea
Compare
Review & tested, looking good |
btw, the fixup fa8fd20 should not go in the readme commit |
Yes my bad , I will fix that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one thing that may be important:
when the tests are launched, snapshots are created with the name you give, but three times each with -chromium-linux.png
or -firefox-linux.png
added, so we have yet 16 png files, when I launch them on macos, playwright generates 16 new files with -chromium-darwin.png
or -firefox-darwin.png
Good catch! I think we can add a control to run the snapshot assertion only on Linux. The method toHaveScreenshot() generates images based on the operating system and browser, and we can't maintain multiple screenshots for every OS and browser combination |
that's the wisest solution I think |
Signed-off-by: maymanaf <med.aymen.naf@gmail.com>
Signed-off-by: maymanaf <med.aymen.naf@gmail.com>
fa8fd20
to
9695162
Compare
Closes #8651