Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add speed space chart e2e test #9829

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Maymanaf
Copy link
Contributor

Closes #8651

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 22, 2024
@Maymanaf Maymanaf force-pushed the aba/e2e-gev-snapshot-test branch 7 times, most recently from 7ce7004 to fdc276e Compare November 26, 2024 08:49
@Maymanaf Maymanaf marked this pull request as ready for review November 26, 2024 08:49
@Maymanaf Maymanaf requested a review from a team as a code owner November 26, 2024 08:50
@Maymanaf Maymanaf requested a review from a team as a code owner November 27, 2024 16:13
@anisometropie
Copy link
Contributor

Review & tested, looking good

@anisometropie
Copy link
Contributor

btw, the fixup fa8fd20 should not go in the readme commit

@Maymanaf
Copy link
Contributor Author

btw, the fixup fa8fd20 should not go in the readme commit

Yes my bad , I will fix that

Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing that may be important:

when the tests are launched, snapshots are created with the name you give, but three times each with -chromium-linux.png or -firefox-linux.png added, so we have yet 16 png files, when I launch them on macos, playwright generates 16 new files with -chromium-darwin.png or -firefox-darwin.png

@Maymanaf
Copy link
Contributor Author

one thing that may be important:

when the tests are launched, snapshots are created with the name you give, but three times each with -chromium-linux.png or -firefox-linux.png added, so we have yet 16 png files, when I launch them on macos, playwright generates 16 new files with -chromium-darwin.png or -firefox-darwin.png

Good catch! I think we can add a control to run the snapshot assertion only on Linux. The method toHaveScreenshot() generates images based on the operating system and browser, and we can't maintain multiple screenshots for every OS and browser combination
What do you think ?

@Yohh
Copy link
Contributor

Yohh commented Nov 28, 2024

that's the wisest solution I think

Signed-off-by: maymanaf <med.aymen.naf@gmail.com>
Signed-off-by: maymanaf <med.aymen.naf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: GEV e2e tests
3 participants