front: add memoization to use scenario data and sub hooks #9833
+93
−69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the results returned by use scenario data are used as dependencies of other hooks, but they are not memoized, causing code to possibly rerun too often.
Also turns a non async useeffect into a usememo. However, this change sometimes create an error in [formatElectrificationRanges <- preparePathPropertiesData <- (usememo in useSpeedSpaceChart)] where associatedProfile is undefined, for some reason I don't understand. I wrapped the function in a try right now, but I believe this should be fixed before considering merging. I also kept the dependency array as is for now, but I'm not of a fan of lying in the dependencies arrays.