core: update stdcm with temporary speed limits #9837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:core
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9837 +/- ##
==========================================
- Coverage 38.18% 38.17% -0.01%
==========================================
Files 996 996
Lines 92033 92033
Branches 1192 1192
==========================================
- Hits 35140 35136 -4
- Misses 56437 56441 +4
Partials 456 456
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sh099078
force-pushed
the
lf/core_add_ltv
branch
from
54525cf
to
258627d
Compare
github-actions
bot
removed
area:front
Sh099078
force-pushed
the
lf/core_add_ltv
branch
4 times, most recently
from
e3a3b09
to
6e9b39a
Compare
eckter
reviewed
Nov 27, 2024
There was a problem hiding this comment.
Nice job!
Having the TemporarySpeedLimitManager inside the PathProperties is quite an invasive change, having to pass it around everywhere. I think I would have preferred if it were handled in the same way as train tags: the path properties only contains "static" data, and we input extra dynamic data when computing the MRSP. We'd still have to pass it around but only up to STDCMSimulations, not all the way down to path properties.
.../kt-osrd-sim-infra/src/main/kotlin/fr/sncf/osrd/sim_infra/impl/TemporarySpeedLimitManager.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/api/api_v2/stdcm/STDCMEndpointV2.kt
Outdated
Show resolved
Hide resolved
Sh099078
force-pushed
the
lf/core_add_ltv
branch
from
6e9b39a
to
53436ce
Compare
Sh099078
force-pushed
the
lf/core_add_ltv
branch
from
3b3ab4a
to
8c84de2
Compare
eckter
approved these changes
Nov 28, 2024
core/src/main/java/fr/sncf/osrd/standalone_sim/StandaloneSim.java
Outdated
Show resolved
Hide resolved
.../kt-osrd-sim-infra/src/main/kotlin/fr/sncf/osrd/sim_infra/impl/TemporarySpeedLimitManager.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/api/api_v2/stdcm/STDCMEndpointV2.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/api/pathfinding/PathPropUtils.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/stdcm/graph/EngineeringAllowanceManager.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/stdcm/infra_exploration/InfraExplorer.kt
Outdated
Show resolved
Hide resolved
Sh099078
force-pushed
the
lf/core_add_ltv
branch
3 times, most recently
from
07f3397
to
5a36131
Compare
Co-authored-by: Younes Khoudli <younes.khoudli@epita.fr> Signed-off-by: Loup Federico <16464925+Sh099078@users.noreply.github.com>
Sh099078
force-pushed
the
lf/core_add_ltv
branch
from
5a36131
to
e3fe49d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8707
Add a list of temporary speed limits in the incoming STDCM requests and apply them to the pathfinding